danwizard208
/
charred-gold
1
0
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Wiki Activity
Labels Milestones

Create a generic Stock class #8

Closed
danwizard208 wants to merge 0 commits from stock-ruby-class into main
Conversation 1 Commits N/A Files Changed N/A
danwizard208 commented 2 years ago
Owner

This creates a generic stock class, along with stock metadata file, to hold in one place all of the common traits, stride, starting stats, etc. of a stock, rather than keeping them in loose files, or hardcoded in javascript source. It also contains the accompanying changes to the data loading, endpoint, and javascript to use the new stock object. As part of this, it also removes hardcoded restrictions to have the stock be one of the canon ones.

This lays the groundwork for allowing servers to include custom stocks.

This creates a generic stock class, along with stock metadata file, to hold in one place all of the common traits, stride, starting stats, etc. of a stock, rather than keeping them in loose files, or hardcoded in javascript source. It also contains the accompanying changes to the data loading, endpoint, and javascript to use the new stock object. As part of this, it also removes hardcoded restrictions to have the stock be one of the canon ones. This lays the groundwork for allowing servers to include custom stocks.
danwizard208 added 20 commits 2 years ago
cadaed9c1e Remove common traits from lifepaths
941e635b84 Delete starting stats files
d9d95f5774 Replace references to stock_objs with just stocks
eb856f6f54 Lookup stocks by adjective field
danwizard208 requested review from silverwizard 2 years ago
danwizard208 self-assigned this 2 years ago
danwizard208 force-pushed stock-ruby-class from eb856f6f54 to 74ed09d830 2 years ago
danwizard208 added 4 commits 2 years ago
42ffa31a3f Remove debug logging
0782b4465e Debug behaviour should default to false
danwizard208 added 1 commit 2 years ago
c8adc19846 Load stock data on stock change or char upload
danwizard208 commented 2 years ago
Poster
Owner

Included in !11.

Included in !11.
danwizard208 closed this pull request 2 years ago

Reviewers

silverwizard was requested for review 2 years ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
silverwizard
Labels
Apply labels
Clear labels
bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed wontfix
This won't be fixed
No Label bug duplicate enhancement help wanted invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
danwizard208
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: danwizard208/charred-gold#8
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'stock-ruby-class'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes