Labels Milestones

remove_key_leads #23

Merged

danwizard208 merged 9 commits from remove_key_leads into main 1 month ago

Conversation 0 Commits 9 Files Changed 22

danwizard208 commented 5 months ago

Owner

Changes a few things in code, but should result in functionally the same for users.

• Removes the setting type (Setting/Subsetting) from the setting names in the data, and has it computed dynamically
• The displayed lifepath has a section displaying leads with shortened names; these were pulled from a 'leads' field on each lifepaths data, but that has been replaced with a list of setting short names at the root of the lifepath data file. All references to the old 'leads' field have been removed; the actual names of the leads used by code was present in the 'key_leads' field, which has been renamed to the now vacated 'leads'.
  All leads should display as before, both in the displayed lifepath list and the selectable setting list, and all leads should function as before.

Changes a few things in code, but should result in functionally the same for users. * Removes the setting type (Setting/Subsetting) from the setting names in the data, and has it computed dynamically * The displayed lifepath has a section displaying leads with shortened names; these were pulled from a 'leads' field on each lifepaths data, but that has been replaced with a list of setting short names at the root of the lifepath data file. All references to the old 'leads' field have been removed; the actual names of the leads used by code was present in the 'key_leads' field, which has been renamed to the now vacated 'leads'. All leads should display as before, both in the displayed lifepath list and the selectable setting list, and all leads should function as before.

danwizard208 added 7 commits 5 months ago

90afb26ccb Change setting type to dynamically calculated ...

Remove it from in the data

a66eeed735 Use isSubsetting function

ee8138c54b Parse lead short names and use them

6f78516bab Add setting short names to lifepath data files

0ed4866b32 Remove leads field from data files

7f5c174810 Change key_leads to leads ...

The leads field for display names has been removed, freeing up the name for the actual leads

583dc5e188 Rename missed 'keyLeads'

danwizard208 added the

enhancement

label 5 months ago

silverwizard approved these changes 5 months ago

silverwizard left a comment

Owner

It looks good - but obviously - test

It looks good - but obviously - test

danwizard208 added 1 commit 5 months ago

6b09b32c43 Fix some no leads fields issues

danwizard208 added 1 commit 4 months ago

e940e4cc91 Bump version

danwizard208 merged commit 365616e365 into main 1 month ago

danwizard208 referenced this issue from a commit 1 month ago

Merge pull request 'remove_key_leads' (#23) from remove_key_leads into main

Reviewers

silverwizard approved these changes 5 months ago

The pull request has been merged as 365616e365.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

silverwizard

Labels

Apply labels

Clear labels

bug
Something is not working duplicate
This issue or pull request already exists enhancement
New feature help wanted
Need some help invalid
Something is wrong question
More information is needed stretch wontfix
This won't be fixed

No Label bug duplicate enhancement help wanted invalid question stretch wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: danwizard208/charred-gold#23

Write Preview

Loading…

Cancel

Save

There is no content yet.